Frequently Asked Questions

Date of slack thread: 4/18/24

Anonymous: hello! have some UX feedback

1. requiring changes to be approved is great, but it’s nonobvious that once your change is approved, you still need to go back into the UI to commit it- we end up realizing later on (sometimes much later- today it was a change approved in Feb) that our change was never applied
2. a callout on misconfigured % rollout would be great- we had an issue where we set a rollout as a % of any of an empty list so no one actually got the feature

Jiakan Wang (Statsig): Thanks for sharing the feedback.

re: #1, we can’t commit your change right after it’s approved by someone else, because you never want to time your release schedule based on when the reviewer decides to approve the change, e.g. Saturday midnight. This is exactly how github works too. It’s also not the same person approving and committing the change, so the author will nonetheless need to come back at a later time after they put their change up for review to commit it. We have notifications for that, but this is something people will need to learn to do, just like they need to learn to commit their code after the PR is approved.

re: #2, typically we won’t be able to tell what is “misconfigured”, unless it falls into a subset of rules that are predefined by us, e.g. if the pass % is negative, or greater than 100.

Anonymous: for 1, I didn’t mean that we don’t like the behavior, just that it would be nice if that were more obvious in the UI- eg I think when you send a change to be approved it doesn’t indicate that next steps will be on you once it is approved; reminders that we have approved but uncommitted changes would also be really nice, maybe more callouts of that state in the UI, etc